Code review

components/address-input.jsx

@@ -54,7 +54,7 @@ export default class AddressInput extends React.Component {
     }
 
     /**
-     * @param event
+     * @param {React.ChangeEvent<HTMLInputElement>} event
      */
     handleChange(event) {
         let state = this.state;

components/sender-address-table.jsx

@@ -30,7 +30,7 @@ export default class SenderAddressTable extends React.Component {
     }
 
     /**
-     * @param event
+     * @param {MouseEvent} event
      */
     handleClickAdd(event) {
         event.preventDefault();
@@ -51,7 +51,7 @@ export default class SenderAddressTable extends React.Component {
     }
 
     /**
-     * @param event
+     * @param {MouseEvent} event
      */
     handleClickDelete(event) {
         event.preventDefault();

src/SenderAddress.php

@@ -48,4 +48,20 @@ class SenderAddress extends AbstractSenderAddress {
         return $address;
     }
 
+	/**
+	 * Create addresses from settings.
+	 *
+	 * @param string $sender_address_settings JSON string.
+	 *
+	 * @return SenderAddress[]
+	 */
+	public static function create_sender_addresses_from_settings( $sender_address_settings ) {
+		$sender_addresses = [];
+		foreach ( json_decode( $sender_address_settings, true ) as $box_setting ) {
+			$sender_addresses[] = SenderAddress::create_from_array( $box_setting );
+		}
+
+		return $sender_addresses;
+	}
+
 }

src/SenderAddressFactory.php

-<?php
-
-
-namespace WpDesk\WooCommerce\ShippingMethod\Fields\SenderAddress;
-
-use WpDesk\WooCommerce\ShippingMethod\SenderAddress;
-
-class SenderAddressFactory {
-
-    /**
-     * Create addresses from settings.
-     *
-     * @param string $sender_address_settings
-     *
-     * @return SenderAddress[]
-     */
-    public static function create_sender_addresses_from_settings( $sender_address_settings ) {
-	    $sender_addresses = [];
-	    foreach ( json_decode( $sender_address_settings, true ) as $box_setting ) {
-		    $sender_addresses[] = SenderAddress::create_from_array( $box_setting );
-	    }
-
-	    return $sender_addresses;
-    }
-
-}

src/ShippingMethodRenderSettingsTrait.php

@@ -9,6 +9,7 @@ namespace WpDesk\WooCommerce\ShippingMethod\Fields\SenderAddress;
 
 /**
  * Can render settings html.
+ * For use in shipping method when sender_addresses field is used in shipping method settings.
  */
 trait ShippingMethodRenderSettingsTrait {
 
@@ -19,7 +20,9 @@ trait ShippingMethodRenderSettingsTrait {
 	 * @return string
 	 */
 	public function get_field_key( $key ) {
-		return $this->plugin_id . $this->id . '_' . $key;
+		/** @var \WC_Shipping_Method $shipping_method */
+		$shipping_method = $this;
+		return $shipping_method->plugin_id . $shipping_method->id . '_' . $key;
 	}
 
 	/**
@@ -59,7 +62,9 @@ trait ShippingMethodRenderSettingsTrait {
 	 * @return string
 	 */
 	public function generate_sender_addresses_html( $key, $data ) {
-		$data['value'] = $this->get_option( $key );
+		/** @var \WC_Shipping_Method $shipping_method */
+		$shipping_method = $this;
+		$data['value'] = $shipping_method->get_option( $key );
 		$data = $this->get_field_params( $key, $data );
 		$settings_field = new SettingsField( $data['field_key'] );
 		ob_start();