Merge branch 'feature/strong-typing-pp' into 'feature/strong-typing'

Feature/strong typing pp

See merge request !23

composer.json

@@ -20,7 +20,7 @@
 		"ext-curl": "*",
 		"ext-json": "*",
 		"wpdesk/wp-persistence": "^2.0|^3.0",
-		"wpdesk/wp-view": "^1.1"
+		"wpdesk/wp-view": "^2"
 	},
 	"require-dev": {
 		"phpunit/phpunit": "<7",

src/ContainerForm.php

@@ -11,6 +11,7 @@ use WPDesk\Persistence\PersistentContainer;
  * @package WPDesk\Forms
  */
 interface ContainerForm {
+
 	/**
 	 * @param ContainerInterface $data
 	 *

src/Escaper.php

@@ -3,6 +3,7 @@
 namespace WPDesk\Forms;
 
 interface Escaper {
+
 	/** @param mixed $value */
 	public function escape( $value ): string;
 }

src/Field.php

@@ -11,6 +11,7 @@ namespace WPDesk\Forms;
  * @package WPDesk\Forms
  */
 interface Field {
+
 	public function get_name(): string;
 
 	/** @return mixed */

src/Field/BasicField.php

@@ -2,6 +2,7 @@
 
 namespace WPDesk\Forms\Field;
 
+use BadMethodCallException;
 use WPDesk\Forms\Field;
 use WPDesk\Forms\Sanitizer;
 use WPDesk\Forms\Sanitizer\NoSanitize;
@@ -17,6 +18,7 @@ use WPDesk\Forms\Validator\RequiredValidator;
  * @package WPDesk\Forms
  */
 abstract class BasicField implements Field {
+
 	use Field\Traits\HtmlAttributes;
 
 	const DEFAULT_PRIORITY = 10;
@@ -57,7 +59,7 @@ abstract class BasicField implements Field {
 	}
 
 	public function get_serializer(): Serializer {
-		throw new \BadMethodCallException('You must define your serializer in a child class.');
+		throw new BadMethodCallException( 'You must define your serializer in a child class.' );
 	}
 
 	final public function get_name(): string {
@@ -154,33 +156,32 @@ abstract class BasicField implements Field {
 		return $this->attributes['id'] ?? sanitize_title( $this->get_name() );
 	}
 
-
 	final public function is_multiple(): bool {
-		return $this->attributes['multiple'];
+		return isset( $this->attributes['multiple'] );
 	}
 
 	final public function set_disabled(): Field {
-		$this->attributes['disabled'] = true;
+		$this->attributes['disabled'] = 'disabled';
 
 		return $this;
 	}
 
 	final public function is_disabled(): bool {
-		return $this->attributes['disabled'];
+		return $this->attributes['disabled'] ?? false;
 	}
 
 	final public function set_readonly(): Field {
-		$this->attributes['readonly'] = true;
+		$this->attributes['readonly'] = 'readonly';
 
 		return $this;
 	}
 
 	final public function is_readonly(): bool {
-		return $this->attributes['readonly'];
+		return $this->attributes['readonly'] ?? false;
 	}
 
 	final public function set_required(): Field {
-		$this->attributes['required'] = true;
+		$this->attributes['required'] = 'required';
 
 		return $this;
 	}
@@ -231,7 +232,7 @@ abstract class BasicField implements Field {
 	}
 
 	final public function is_required(): bool {
-		return $this->attributes['required'];
+		return isset( $this->attributes['required'] );
 	}
 
 	final public function get_priority(): int {

src/Field/ButtonField.php

@@ -3,6 +3,7 @@
 namespace WPDesk\Forms\Field;
 
 class ButtonField extends NoValueField {
+
 	public function get_template_name(): string {
 		return 'button';
 	}

src/Field/CheckboxField.php

@@ -5,6 +5,7 @@ namespace WPDesk\Forms\Field;
 use WPDesk\Forms\Field;
 
 class CheckboxField extends BasicField {
+
 	const VALUE_TRUE  = 'yes';
 	const VALUE_FALSE = 'no';
 

src/Field/DatePickerField.php

@@ -6,6 +6,7 @@ use WPDesk\Forms\Sanitizer;
 use WPDesk\Forms\Sanitizer\TextFieldSanitizer;
 
 class DatePickerField extends BasicField {
+
 	public function __construct() {
 		$this->add_class( 'date-picker' );
 		$this->set_placeholder( 'YYYY-MM-DD' );

src/Field/Header.php

@@ -5,7 +5,9 @@ namespace WPDesk\Forms\Field;
 use WPDesk\Forms\Field;
 
 class Header extends NoValueField {
+
 	public function __construct() {
+		parent::__construct();
 		$this->meta['header_size'] = '';
 	}
 

src/Field/HiddenField.php

@@ -6,6 +6,7 @@ use WPDesk\Forms\Sanitizer;
 use WPDesk\Forms\Sanitizer\TextFieldSanitizer;
 
 class HiddenField extends BasicField {
+
 	public function get_type(): string {
 		return 'hidden';
 	}

src/Field/InputEmailField.php

@@ -6,6 +6,7 @@ use WPDesk\Forms\Sanitizer;
 use WPDesk\Forms\Sanitizer\EmailSanitizer;
 
 class InputEmailField extends BasicField {
+
 	public function get_type(): string {
 		return 'email';
 	}

src/Field/InputNumberField.php

@@ -6,6 +6,7 @@ use WPDesk\Forms\Sanitizer;
 use WPDesk\Forms\Sanitizer\TextFieldSanitizer;
 
 class InputNumberField extends BasicField {
+
 	public function get_type(): string {
 		return 'number';
 	}

src/Field/InputTextField.php

@@ -6,6 +6,7 @@ use WPDesk\Forms\Sanitizer;
 use WPDesk\Forms\Sanitizer\TextFieldSanitizer;
 
 class InputTextField extends BasicField {
+
 	public function get_sanitizer(): Sanitizer {
 		return new TextFieldSanitizer();
 	}

src/Field/MultipleInputTextField.php

@@ -3,6 +3,7 @@
 namespace WPDesk\Forms\Field;
 
 class MultipleInputTextField extends InputTextField {
+
 	public function get_template_name(): string {
 		return 'input-text-multiple';
 	}

src/Field/NoValueField.php

@@ -8,6 +8,7 @@ namespace WPDesk\Forms\Field;
  * @package WPDesk\Forms
  */
 abstract class NoValueField extends BasicField {
+
 	public function __construct() {
 		$this->set_name( '' );
 	}

src/Field/Paragraph.php

@@ -3,6 +3,7 @@
 namespace WPDesk\Forms\Field;
 
 class Paragraph extends NoValueField {
+
 	public function get_template_name(): string {
 		return 'paragraph';
 	}

src/Field/ProductSelect.php

@@ -6,6 +6,7 @@ use WPDesk\Forms\Serializer\ProductSelectSerializer;
 use WPDesk\Forms\Serializer;
 
 class ProductSelect extends SelectField {
+
 	public function __construct() {
 		$this->set_multiple();
 	}

src/Field/RadioField.php

@@ -3,6 +3,7 @@
 namespace WPDesk\Forms\Field;
 
 class RadioField extends BasicField {
+
 	public function get_template_name(): string {
 		return 'input-radio';
 	}

src/Field/SelectField.php

@@ -18,7 +18,7 @@ class SelectField extends BasicField {
 	}
 
 	public function set_multiple(): Field {
-		$this->attributes['multiple'] = true;
+		$this->attributes['multiple'] = 'multiple';
 
 		return $this;
 	}

src/Field/SubmitField.php

@@ -3,6 +3,7 @@
 namespace WPDesk\Forms\Field;
 
 class SubmitField extends NoValueField {
+
 	public function get_template_name(): string {
 		return 'input-submit';
 	}