Skip to content
Snippets Groups Projects
Commit 97ee4c0b authored by Grzegorz Rola's avatar Grzegorz Rola
Browse files

Code review changes.

parent 27f8c40c
No related branches found
No related tags found
1 merge request!12Feature/plugin activation
Pipeline #7307 failed
...@@ -27,7 +27,7 @@ class LegacyBuildDirector { ...@@ -27,7 +27,7 @@ class LegacyBuildDirector {
} }
/** /**
* Returns built pluginPluginAccess.php * Returns built plugin
* *
* @return AbstractPlugin * @return AbstractPlugin
*/ */
......
<?php <?php
/**
* Created by PhpStorm.
* User: grola
* Date: 25.07.18
* Time: 16:55
*/
namespace WPDesk\PluginBuilder\Plugin; namespace WPDesk\PluginBuilder\Plugin;
......
...@@ -16,7 +16,7 @@ trait HookableParent { ...@@ -16,7 +16,7 @@ trait HookableParent {
* *
* @param Hookable|HookablePluginDependant $hookable_object Hookable object. * @param Hookable|HookablePluginDependant $hookable_object Hookable object.
*/ */
public function add_hookable( $hookable_object ) { public function add_hookable( Hookable $hookable_object ) {
if ( $hookable_object instanceof HookablePluginDependant ) { if ( $hookable_object instanceof HookablePluginDependant ) {
$hookable_object->set_plugin( $this ); $hookable_object->set_plugin( $this );
} }
...@@ -26,7 +26,7 @@ trait HookableParent { ...@@ -26,7 +26,7 @@ trait HookableParent {
/** /**
* Run hooks method on all hookable objects. * Run hooks method on all hookable objects.
*/ */
protected function hooks_no_hookable_objects() { protected function hooks_on_hookable_objects() {
/** @var Hookable $hookable_object $hookable_object */ /** @var Hookable $hookable_object $hookable_object */
foreach ( $this->hookable_objects as $hookable_object ) { foreach ( $this->hookable_objects as $hookable_object ) {
$hookable_object->hooks(); $hookable_object->hooks();
......
...@@ -2,21 +2,21 @@ ...@@ -2,21 +2,21 @@
namespace WPDesk\PluginBuilder\Plugin; namespace WPDesk\PluginBuilder\Plugin;
trait Template { trait TemplateLoad {
/** /**
* Plugin path. * Plugin path.
* *
* @var string * @var string
*/ */
public $plugin_path; protected $plugin_path;
/** /**
* Template path. * Template path.
* *
* @var string * @var string
*/ */
public $template_path; protected $template_path;
/** /**
* Init base variables for plugin * Init base variables for plugin
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment