Bugfix/wordpress review

na review wordpressa doczepili się o to że wyświetlanie zmiennej $notice nie jest escapowane i o text-domain że jest w zmiennej a nie jest zwykłym stringiem.

src/Basic_Requirement_Checker.php

@@ -231,19 +231,19 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 			$notices = array();
 			if ( ! self::is_php_at_least( $this->min_php_version ) ) {
 				$notices[] = $this->prepare_notice_message( sprintf( __( 'The “%s” plugin cannot run on PHP versions older than %s. Please contact your host and ask them to upgrade.',
-					"wp-basic-requirements" ), esc_html( $this->plugin_name ), $this->min_php_version ) );
+					'wp-basic-requirements' ), esc_html( $this->plugin_name ), $this->min_php_version ) );
 			}
 			if ( ! self::is_wp_at_least( $this->min_wp_version ) ) {
 				$notices[] = $this->prepare_notice_message( sprintf( __( 'The “%s” plugin cannot run on WordPress versions older than %s. Please update WordPress.',
-					"wp-basic-requirements" ), esc_html( $this->plugin_name ), $this->min_wp_version ) );
+					'wp-basic-requirements' ), esc_html( $this->plugin_name ), $this->min_wp_version ) );
 			}
 			if ( $this->min_wc_version !== null && $this->can_check_plugin_version() && ! self::is_wc_at_least( $this->min_wc_version ) ) {
 				$notices[] = $this->prepare_notice_message( sprintf( __( 'The “%s” plugin cannot run on WooCommerce versions older than %s. Please update WooCommerce.',
-					"wp-basic-requirements" ), esc_html( $this->plugin_name ), $this->min_wc_version ) );
+					'wp-basic-requirements' ), esc_html( $this->plugin_name ), $this->min_wc_version ) );
 			}
 			if ( $this->min_openssl_version !== null && ! self::is_open_ssl_at_least( $this->min_openssl_version ) ) {
 				$notices[] = $this->prepare_notice_message( sprintf( __( 'The “%s” plugin cannot run without OpenSSL module version at least %s. Please update OpenSSL module.',
-					"wp-basic-requirements" ), esc_html( $this->plugin_name ),
+					'wp-basic-requirements' ), esc_html( $this->plugin_name ),
 					'0x' . dechex( $this->min_openssl_version ) ) );
 			}
 
@@ -336,7 +336,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 					if ( isset( $plugin['Version'] ) && version_compare( $plugin['Version'], $plugin[ self::PLUGIN_INFO_APPEND_PLUGIN_DATA ], '<=' ) ) {
 						$notices[] = $this->prepare_notice_message(
 							sprintf(
-								__( 'The &#8220;%1$s&#8221; plugin requires at least %2$s version of %3$s to work correctly. Please update it to its latest release.', "wp-basic-requirements" ),
+								__( 'The &#8220;%1$s&#8221; plugin requires at least %2$s version of %3$s to work correctly. Please update it to its latest release.', 'wp-basic-requirements' ),
 								esc_html( $this->plugin_name ),
 								$plugin[ self::PLUGIN_INFO_APPEND_PLUGIN_DATA ],
 								$plugin['Name']
@@ -464,7 +464,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 						$notice = $this->prepare_plugin_repository_require_notice( $plugin_info );
 					} elseif ( ! self::is_wp_plugin_active( $plugin_name ) ) {
 						$notice = $this->prepare_notice_message( sprintf( __( 'The &#8220;%s&#8221; plugin cannot run without %s active. Please install and activate %s plugin.',
-							"wp-basic-requirements" ), esc_html( $this->plugin_name ),
+							'wp-basic-requirements' ), esc_html( $this->plugin_name ),
 							esc_html( basename( $plugin_info[ self::PLUGIN_INFO_KEY_NICE_NAME ] ) ),
 							esc_html( basename( $plugin_info[ self::PLUGIN_INFO_KEY_NICE_NAME ] ) ) ) );
 					}
@@ -509,7 +509,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 					$install_url = $this->prepare_plugin_repository_install_url( $plugin_info );
 
 					return $this->prepare_notice_message( sprintf( wp_kses( __( 'The &#8220;%s&#8221; plugin requires free %s plugin. <a href="%s">Install %s</a>',
-						"wp-basic-requirements" ), array( 'a' => array( 'href' => array() ) ) ),
+						'wp-basic-requirements' ), array( 'a' => array( 'href' => array() ) ) ),
 						$this->plugin_name, $nice_name, esc_url( $install_url ), $nice_name ) );
 				}
 				$activate_url = 'plugins.php?action=activate&plugin=' . urlencode( $plugin_info[ self::PLUGIN_INFO_KEY_NAME ] ) . '&plugin_status=all&paged=1&s';
@@ -518,7 +518,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 				}
 
 				return $this->prepare_notice_message( sprintf( wp_kses( __( 'The &#8220;%s&#8221; plugin requires activating %s plugin. <a href="%s">Activate %s</a>',
-					"wp-basic-requirements" ), array( 'a' => array( 'href' => array() ) ) ),
+					'wp-basic-requirements' ), array( 'a' => array( 'href' => array() ) ) ),
 					$this->plugin_name, $nice_name, esc_url( admin_url( $activate_url ) ), $nice_name ) );
 			}
 
@@ -566,7 +566,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 				foreach ( $this->module_require as $module_name => $nice_module_name ) {
 					if ( ! self::is_module_active( $module_name ) ) {
 						$notices[] = $this->prepare_notice_message( sprintf( __( 'The &#8220;%s&#8221; plugin cannot run without %s PHP module installed. Please contact your host and ask them to install %s.',
-							"wp-basic-requirements" ), esc_html( $this->plugin_name ),
+							'wp-basic-requirements' ), esc_html( $this->plugin_name ),
 							esc_html( basename( $nice_module_name ) ), esc_html( basename( $nice_module_name ) ) ) );
 					}
 				}
@@ -594,7 +594,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
 				foreach ( $this->setting_require as $setting => $value ) {
 					if ( ! self::is_setting_set( $setting, $value ) ) {
 						$notices[] = $this->prepare_notice_message( sprintf( __( 'The &#8220;%s&#8221; plugin cannot run without %s PHP setting set to %s. Please contact your host and ask them to set %s.',
-							"wp-basic-requirements" ), esc_html( $this->plugin_name ),
+							'wp-basic-requirements' ), esc_html( $this->plugin_name ),
 							esc_html( basename( $setting ) ),
 							esc_html( basename( $value ) ), esc_html( basename( $setting ) ) ) );
 					}