Skip to content
Snippets Groups Projects
Commit 3d5aa73e authored by Marcin Kolanko's avatar Marcin Kolanko
Browse files

Merge branch 'bugfix/prevent-error-notice' into 'master'

fix: prevent error notice

See merge request !44
parents b36f72cd bd00d301
No related branches found
No related tags found
1 merge request!44fix: prevent error notice
Pipeline #353068 failed with stages
in 29 seconds
## [3.6.3] - 2024-04-16
### Fixed
- Prevent error notice
## [3.6.2] - 2023-06-29
### Fixed
- Exact comparison for X.Y.Z semver version doesn't result in notices when the required version is met. Previously, requiring plugin in 1.1.1 version and activating dependend plugin in such version would result in admin notice and disabling the plugin, actually letting to use the plugin only from 1.1.2 version.
......
......@@ -333,7 +333,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
$required_plugins = $this->retrieve_required_plugins_data();
if ( count( $required_plugins ) > 0 ) {
foreach ( $required_plugins as $plugin ) {
if ( version_compare( $plugin['Version'], $plugin[ self::PLUGIN_INFO_APPEND_PLUGIN_DATA ], '<=' ) ) {
if ( isset( $plugin['Version'] ) && version_compare( $plugin['Version'], $plugin[ self::PLUGIN_INFO_APPEND_PLUGIN_DATA ], '<=' ) ) {
$notices[] = $this->prepare_notice_message(
sprintf(
__( 'The &#8220;%1$s&#8221; plugin requires at least %2$s version of %3$s to work correctly. Please update it to its latest release.', $this->get_text_domain() ),
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment