Skip to content
Snippets Groups Projects
Select Git revision
  • include-composer-json
  • master default protected
  • feat/npm-publish
  • feat/demo-deploy
  • change-demo-deploy
  • remove-smoke
  • feat/acceptance-tests
  • feature/deploy-composer.json
  • feature/mysql-bin-logs
  • skip-codecept-for-libs
  • exclude-wp-assets
  • update_codecept_image
  • fix/silenced-copy
  • remove-free-translations
  • codeception-with-optional-step
  • improve-parallelization
  • linter-exit
  • change-images
  • fix/linter
  • globally-raise-mem-limit
  • no-symlink2
21 results

gitlab-ci

Bart Jaskulski's avatar
Bartek Jaskulski authored
Following WordPress Plugin Review Team recommendation, allow original
`composer.json` file to be available in distribution package.

The reasoning of WP Team:

> We noticed that your plugin is using Composer to handle library
> dependencies, that's great as it will help maintaining and updating
> your plugin in the future while avoiding collisions with other plugins
> that are using same libraries. The composer.json file describes the
> dependencies of your project and may contain other metadata as
> well. It's a small file that typically can be found in the top-most
> directory of your plugin. As one of the strengths of open source is
> the ability to review, observe, and adapt code, we would like to ask
> you to include that file in your plugin, even if it is only used for
> development purposes. This will allow others to exercise the open
> source freedoms from which we all benefit.

It's best to comply with those recommendation to avoid bounce-backs in
the future during free plugin review, considering that `composer.json`
itself will not cause any harm and will not reveal any disclosed
information about our plugin architecture or company internals.

Following, I don't think it is necessary to include `composer.lock` file,
which holds the information of exact version of installed dependencies.

Signed-off-by: default avatarBart Jaskulski <bjaskulski@protonmail.com>
d2e29d45
History
Name Last commit Last update