Skip to content
Snippets Groups Projects
Select Git revision
  • bc8464ccbbaf09be0c4ee9d3c3889befad4f64bb
  • master default protected
  • feat/npm-publish
  • feat/demo-deploy
  • change-demo-deploy
  • remove-smoke
  • feat/acceptance-tests
  • feature/deploy-composer.json
  • feature/mysql-bin-logs
  • skip-codecept-for-libs
  • include-composer-json
  • exclude-wp-assets
  • update_codecept_image
  • fix/silenced-copy
  • remove-free-translations
  • codeception-with-optional-step
  • improve-parallelization
  • linter-exit
  • change-images
  • fix/linter
  • globally-raise-mem-limit
  • no-symlink2
22 results

lint.yml

Blame
    • Bartek Jaskulski's avatar
      bc8464cc
      fix: don't interfere with stdout/stderr in linter · bc8464cc
      Bartek Jaskulski authored
      
      `php -l` is inconsistent in it's return codes, as it may exit 0 on
      correct code, but while encountering parse errors, it may end up with
      0 or 255, but the message is sent do `stdout` instead of `stderr`. This
      may seem irrelevant but have some serious implications.
      
      If we decide to ignore `stdout` (which is better for readable job trace),
      we may end up with error exit code but without error message, impossible
      to detect. On the other hand, if we send all `stderr` output to
      `/dev/null`, we consequently ignore most of errors produced by linter,
      thus we think our code is valid, which may not be true.
      
      To keep best of both worlds (succinct output and clear error messages)
      rely on filtering output, to contain only those lines, which may inform
      us about errors and ignore all "No syntax errors" lines as it may be the
      most predictable way.
      
      Signed-off-by: default avatarBart Jaskulski <bjaskulski@protonmail.com>
      Verified
      bc8464cc
      History
      fix: don't interfere with stdout/stderr in linter
      Bartek Jaskulski authored
      
      `php -l` is inconsistent in it's return codes, as it may exit 0 on
      correct code, but while encountering parse errors, it may end up with
      0 or 255, but the message is sent do `stdout` instead of `stderr`. This
      may seem irrelevant but have some serious implications.
      
      If we decide to ignore `stdout` (which is better for readable job trace),
      we may end up with error exit code but without error message, impossible
      to detect. On the other hand, if we send all `stderr` output to
      `/dev/null`, we consequently ignore most of errors produced by linter,
      thus we think our code is valid, which may not be true.
      
      To keep best of both worlds (succinct output and clear error messages)
      rely on filtering output, to contain only those lines, which may inform
      us about errors and ignore all "No syntax errors" lines as it may be the
      most predictable way.
      
      Signed-off-by: default avatarBart Jaskulski <bjaskulski@protonmail.com>
    gitlab-ci-shop.yml 161 B
    include:
      - project: 'wpdesk/gitlab-ci'
        ref: 'master'
        file: '/gitlab-ci-1.2.yml'
    
    deploy to shop:
      when: on_success
    
    deploy to demo:
      when: on_success