From 5e011feb1427ebc0439ab778c96c2ccadb101f92 Mon Sep 17 00:00:00 2001 From: Piotr Potrebka <piotr.potrebka@wpdesk.net> Date: Thu, 15 Dec 2022 20:46:42 +0100 Subject: [PATCH] fix: script version, docs --- CHANGELOG.md | 2 +- src/Plugin/AbstractPlugin.php | 22 +++++++++++++--------- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f6e42ff..4ffcafe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -## [2.1.0] - 2022-11-07 +## [2.1.0] - 2022-12-15 ### Added - plugin path - plugin lang diff --git a/src/Plugin/AbstractPlugin.php b/src/Plugin/AbstractPlugin.php index 5a09b8b..dfb1eff 100644 --- a/src/Plugin/AbstractPlugin.php +++ b/src/Plugin/AbstractPlugin.php @@ -156,7 +156,7 @@ abstract class AbstractPlugin extends SlimPlugin { add_action( 'admin_enqueue_scripts', [ $this, 'admin_enqueue_scripts' ] ); add_action( 'wp_enqueue_scripts', [ $this, 'wp_enqueue_scripts' ] ); add_action( 'plugins_loaded', [ $this, 'load_plugin_text_domain' ] ); - add_filter( 'plugin_action_links_' . plugin_basename( $this->get_plugin_file_path() ), [ $this, 'links_filter' ] ); + add_filter( 'plugin_action_links_' . plugin_basename( $this->get_plugin_file_path() ), [ $this, 'links_filter' ] ); } /** @@ -171,9 +171,11 @@ abstract class AbstractPlugin extends SlimPlugin { /** * Append JS scripts in the WordPress admin panel. This is a hook function. Do not execute directly. * + * @param string $hook_suffix The current admin page passed from WordPress filter. + * * @return void */ - public function admin_enqueue_scripts( $hook = '' ) { + public function admin_enqueue_scripts( $hook_suffix = '' ) { } /** @@ -186,18 +188,20 @@ abstract class AbstractPlugin extends SlimPlugin { /** * @param string $prefix - * @param bool $random * - * @return int|string + * @return string */ - public function get_scripts_version( $prefix = '', $random = false ) { - if ( $random ) { - return time(); - } - + public function get_scripts_version( $prefix = '' ) { return $prefix . $this->plugin_info->get_version(); } + /** + * @return int + */ + public function get_random_script_version() { + return time(); + } + /** * Initialize plugin admin links. This is a hook function. Do not execute directly. * -- GitLab