From bd00d301063b915f1005e2b86abb3915ae0be35f Mon Sep 17 00:00:00 2001
From: Marcin Kolanko <marcin.kolanko@wpdesk.net>
Date: Mon, 15 Apr 2024 15:50:33 +0200
Subject: [PATCH] fix: prevent error notice
---
CHANGELOG.md | 4 ++++
src/Basic_Requirement_Checker.php | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c568dcf..82415f6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## [3.6.3] - 2024-04-16
+### Fixed
+- Prevent error notice
+
## [3.6.2] - 2023-06-29
### Fixed
- Exact comparison for X.Y.Z semver version doesn't result in notices when the required version is met. Previously, requiring plugin in 1.1.1 version and activating dependend plugin in such version would result in admin notice and disabling the plugin, actually letting to use the plugin only from 1.1.2 version.
diff --git a/src/Basic_Requirement_Checker.php b/src/Basic_Requirement_Checker.php
index dcac407..43a8981 100644
--- a/src/Basic_Requirement_Checker.php
+++ b/src/Basic_Requirement_Checker.php
@@ -333,7 +333,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) {
$required_plugins = $this->retrieve_required_plugins_data();
if ( count( $required_plugins ) > 0 ) {
foreach ( $required_plugins as $plugin ) {
- if ( version_compare( $plugin['Version'], $plugin[ self::PLUGIN_INFO_APPEND_PLUGIN_DATA ], '<=' ) ) {
+ if ( isset( $plugin['Version'] ) && version_compare( $plugin['Version'], $plugin[ self::PLUGIN_INFO_APPEND_PLUGIN_DATA ], '<=' ) ) {
$notices[] = $this->prepare_notice_message(
sprintf(
__( 'The “%1$s” plugin requires at least %2$s version of %3$s to work correctly. Please update it to its latest release.', $this->get_text_domain() ),
--
GitLab