From a80aa3cb75bd3059930ee62d5f1e93f0b50f8873 Mon Sep 17 00:00:00 2001 From: dyszczo <krzysztof.dyszczyk@gmail.com> Date: Wed, 18 Sep 2019 20:49:08 +0200 Subject: [PATCH] Better error message display for temporary disabling --- CHANGELOG.md | 4 ++++ src/Basic_Requirement_Checker.php | 2 +- src/Basic_Requirement_Checker_With_Update_Disable.php | 6 +++--- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 47ac443..4a2e502 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## [3.0.2] - 2019-09-18 +### Fixed +- Better new error messages display for temporary disabling + ## [3.0.1] - 2019-09-18 ### Fixed - Better new error messages display diff --git a/src/Basic_Requirement_Checker.php b/src/Basic_Requirement_Checker.php index c6fb7fd..05cd1bc 100644 --- a/src/Basic_Requirement_Checker.php +++ b/src/Basic_Requirement_Checker.php @@ -224,7 +224,7 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker' ) ) { * * @return string */ - private function prepare_notice_message( $message ) { + protected function prepare_notice_message( $message ) { return '<div class="error"><p>' . $message . '</p></div>'; } diff --git a/src/Basic_Requirement_Checker_With_Update_Disable.php b/src/Basic_Requirement_Checker_With_Update_Disable.php index aeaf871..ea2e43d 100644 --- a/src/Basic_Requirement_Checker_With_Update_Disable.php +++ b/src/Basic_Requirement_Checker_With_Update_Disable.php @@ -23,10 +23,10 @@ if ( ! class_exists( 'WPDesk_Basic_Requirement_Checker_With_Update_Disable' ) ) } foreach ( $this->plugin_require as $name => $plugin_info ) { if ( $this->is_currently_updated( $name ) ) { - $nice_name = $plugin_info[self::PLUGIN_INFO_KEY_NICE_NAME]; - $this->notices[] = sprintf( __( 'The “%s” plugin disables temporarily as required %s plugin is being upgraded.', + $nice_name = $plugin_info[ self::PLUGIN_INFO_KEY_NICE_NAME ]; + $this->notices[] = $this->prepare_notice_message( sprintf( __( 'The “%s” plugin disables temporarily as required %s plugin is being upgraded.', $this->get_text_domain() ), - $this->plugin_name, $nice_name, $nice_name ); + $this->plugin_name, $nice_name, $nice_name ) ); } } -- GitLab